spf13 / viper

Go configuration with fangs
MIT License
26.91k stars 2.02k forks source link

AllKeys returns keys in reverse sorted order #1836

Closed dustmop closed 4 months ago

dustmop commented 4 months ago

Returning keys in a stable manner prevents non-determinism. A bug happening in allSettings manifests under certain orders of keys, by using reverse order this bug is never triggered.

github-actions[bot] commented 4 months ago

👋 Thanks for contributing to Viper! You are awesome! 🎉

A maintainer will take a look at your pull request shortly. 👀

In the meantime: We are working on Viper v2 and we would love to hear your thoughts about what you like or don't like about Viper, so we can improve or fix those issues.

⏰ If you have a couple minutes, please take some time and share your thoughts: https://forms.gle/R6faU74qPRPAzchZ9

📣 If you've already given us your feedback, you can still help by spreading the news, either by sharing the above link or telling people about this on Twitter:

https://twitter.com/sagikazarmark/status/1306904078967074816

Thank you! ❤️

CLAassistant commented 4 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 15 committers have signed the CLA.

:white_check_mark: albertvaka
:white_check_mark: hush-hush
:white_check_mark: gbbr
:x: olivielpeau
:x: xlucas
:x: Matthew Hardwick
:x: platinummonkey
:x: knusbaum
:x: mrhwick
:x: sgnn7
:x: mx-psi
:x: djmitche
:x: dustmop
:x: ganeshkumarsv
:x: pgimalac


Matthew Hardwick seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.