spf13 / viper

Go configuration with fangs
MIT License
26.83k stars 2.01k forks source link

Bound environment variables get written to disk #1918

Open darrellwarde opened 6 days ago

darrellwarde commented 6 days ago

Preflight Checklist

Viper Version

1.19.0

Go Version

1.22.5

Config Source

Flags, Environment variables, Files

Format

JSON

Repl.it link

https://replit.com/@darrellwarde/Viper-example

Code reproducing the issue

No response

Expected Behavior

Upon writing config files, I would expect that only the following configuration values would be written to disk:

Actual Behavior

Configuration values from mapped environment variables get written to configuration file if they have values whilst writing config files. This is unexpected because you generally only expect environment variables to effect the behaviour of executions for which they are set, but because of this, they will be persisted to disk and still act as the configuration values when the variables are no longer set.

In the Repl.it, use the shell to set YEARS_SINCE_BORN during execution. Even though age is never explicitly set in the config, it gets written to the config file purely from the environment variable being set during execution.

Steps To Reproduce

No response

Additional Information

No response

github-actions[bot] commented 6 days ago

👋 Thanks for reporting!

A maintainer will take a look at your issue shortly. 👀

In the meantime: We are working on Viper v2 and we would love to hear your thoughts about what you like or don't like about Viper, so we can improve or fix those issues.

⏰ If you have a couple minutes, please take some time and share your thoughts: https://forms.gle/R6faU74qPRPAzchZ9

📣 If you've already given us your feedback, you can still help by spreading the news, either by sharing the above link or telling people about this on Twitter:

https://twitter.com/sagikazarmark/status/1306904078967074816

Thank you! ❤️