spgarbet / tangram

Table Grammar package for R
66 stars 3 forks source link

integration with jamovi #38

Closed sbalci closed 4 years ago

sbalci commented 6 years ago

I think it would be very useful if there is a tangram extension for Jamovi. I thought this when reading this discussion: https://twitter.com/thosjleeper/status/1003227915981553664 https://twitter.com/serdarbalci/status/1008364257505923073

spgarbet commented 6 years ago

I've created an account with Jamovi and will check it out. Shouldn't be too hard.

FYI, I'm refactoring heavily which will make requests like yours easier to do. The first step was removing the need for two calls. It's now context aware with Rmarkdown. Jamovi aware can be done just as easily. Here's the example in the branch: http://htmlpreview.github.io/?https://github.com/spgarbet/tg/blob/knitr/vignettes/example.html

sbalci commented 6 years ago

Thank you very much for your generosity and your contributions. Best wishes.

sbalci commented 6 years ago

Jamovi has an integrated R code editor now: https://blog.jamovi.org/2018/07/30/rj.html I am now using Rj editor and tangram together.

Best wishes

ekran resmi 2018-08-13 14 51 40
sbalci commented 4 years ago

Dear @spgarbet I have implanted tangram package into a jamovi module.

With your permission I would like to submit it to be included in the jamovi when I make final adjustments.

Example screenshot:

Ekran Resmi 2020-01-29 13 42 40

Referenced as:

Ekran Resmi 2020-01-29 13 50 18

Code: https://github.com/sbalci/ClinicoPathJamoviModule https://github.com/sbalci/ClinicoPathJamoviModule/blob/master/R/crosstable.b.R

spgarbet commented 4 years ago

Sedar,

I welcome it's inclusion! This looks like good work. What can I do to help?

On Wed, Jan 29, 2020 at 4:54 AM Serdar Balcı notifications@github.com wrote:

Dear @spgarbet https://github.com/spgarbet I have implanted tangram package into a jamovi module.

With your permission I would like to submit it to be included in the jamovi when I make final adjustments.

Example screenshot: [image: Ekran Resmi 2020-01-29 13 42 40] https://user-images.githubusercontent.com/7208830/73350108-7cd73a00-429d-11ea-8060-c388c47ab5c0.png

Referenced as: [image: Ekran Resmi 2020-01-29 13 50 18] https://user-images.githubusercontent.com/7208830/73350799-c3796400-429e-11ea-9fbd-000c706d8df9.png

Code: https://github.com/sbalci/ClinicoPathJamoviModule

https://github.com/sbalci/ClinicoPathJamoviModule/blob/master/R/crosstable.b.R

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/spgarbet/tangram/issues/38?email_source=notifications&email_token=AAAAV3RLIIBWO6J3GUQLWJTRAFN7ZA5CNFSM4FFMZMUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKGYYQI#issuecomment-579701825, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAAV3X3GEKIBE3K6FM2OCLRAFN7ZANCNFSM4FFMZMUA .

-- Shawn Garbett 615.397.8737

sbalci commented 4 years ago

Thank you very much. I have also contacted jamovi developers @jonathon-love https://github.com/jonathon-love I will update you with progress.

sbalci commented 4 years ago

I have built the module and submitted to jamovi. But since it has many dependencies the module size is big that is why it is not currently included in the jamovi library. It can be installed install using side-load. Thank you very much for your support.

windows: https://library.jamovi.org/win64/R3.6.1/ClinicoPath-0.0.1.jmo macOS: https://library.jamovi.org/macos/R3.6.1/ClinicoPath-0.0.1.jmo https://sbalci.github.io/ClinicoPathJamoviModule/reference/figures/jamovi-sideload.gif Details: https://sbalci.github.io/ClinicoPathJamoviModule/

sbalci commented 4 years ago

Dear @spgarbet , I am updating jamovi module. The recent release gives error that there is no hmisc in the scope. No error when I use 0.3.2

Debug

Error in get(style, envir = globalenv()): 'hmisc' nesnesi bulunamadı

private$.run()
tangram::html5(tangram::tangram(formula, self$data), fragment = TRUE, inline = "nejm.css", caption = paste0("Cross Table NEJM Style for Dependent ", self$options$group), id = "tbl3")
tangram::tangram(formula, self$data)
tangram.formula(formula, self$data)
get(style, envir = globalenv())
spgarbet commented 4 years ago

I know the cause of this and have a sketch of a solution, but our power is out here due to severe storms. Will be a few days.

sbalci commented 4 years ago

Dear @spgarbet thank you for your response. Please take care.

spgarbet commented 4 years ago

Turned into a bug ticket Issue #64