spgarbet / tangram

Table Grammar package for R
67 stars 3 forks source link

Refactor Cell Definitions #6

Closed spgarbet closed 7 years ago

spgarbet commented 7 years ago

Cell definitions are too limited and do not include comprehensive Greek letter values.

Current possible cell definitions.

Open question. What about N value handling?

spgarbet commented 7 years ago

This refactor is going well. It deleted 2 layers in the code, and the first render I've rewritten lost about 1/3 of it's code. Overall it's going to make the whole project more extensible and easier to use. Very pleased with this.

spgarbet commented 7 years ago

Need to finish fixing breakage on rmd, HTML5 and indexing. Otherwise current branch is lookin great. 2 layers of code deleted. No special adapter logic necessary. 1/3 of summary deleted. Will most likely delete more code in last three renderers as well.

spgarbet commented 7 years ago

Working and merged refactor branch.