spgennard / vscode_cobol

Visual Studio Code Extension for COBOL, JCL and MF Directive Files
MIT License
36 stars 16 forks source link

Operator keywords not coloured #29

Closed IntelOrca closed 6 years ago

IntelOrca commented 6 years ago

The following keywords are not coloured:

spgennard commented 6 years ago

b-exor was missing but all the others are already present, for example:

image

IntelOrca commented 6 years ago

What is their classification? My theme must not support the colour.

spgennard commented 6 years ago

keyword.operator.cobol

spgennard commented 6 years ago

What theme are you using?

IntelOrca commented 6 years ago

One Dark Pro

IntelOrca commented 6 years ago

I think it is coloured actually, it is just very subtle. The theme defines lots of other sub operator colours which are more of an aqua and stands out more:

https://github.com/Binaryify/OneDark-Pro/blob/master/themes/OneDark-Pro.json

E.g.

spgennard commented 6 years ago

You can tweak the theme, for example:

"editor.tokenColorCustomizations": { "[One Dark Pro]": { "textMateRules": [ { "scope": "keyword.operator", "settings": { "foreground": "#FF0000" } } ] } }

gives you:

On 2 August 2018 at 09:15, Ted John notifications@github.com wrote:

One Dark Pro

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/spgennard/vscode_cobol/issues/29#issuecomment-409844990, or mute the thread https://github.com/notifications/unsubscribe-auth/AFtrGPrk8MZyFqRN3Czt6npPZMivWKsdks5uMrUMgaJpZM4VqUOF .

--

Stephen Gennard stephen@gennard.net

spgennard commented 6 years ago

Time to close it and I will consider adding this to a faq/wiki