Closed andycrofford closed 2 years ago
GitMensch
commented
2 years ago Thank you for the report.
Do you see the variables in the outline (so the extension in general does recognize them)? Is your workspace marked as "trusted" (so all extensions are fully loaded)?
I am not sure when it stopped working.
Can you please check the easy way with going to the extension view, then select the gear wheel and then "install different version"?
andycrofford
commented
2 years ago Hello,
Yes, they show in the outline and it is in a trusted workspace. The option to "Install Different Version" is grayed out.
On Tue, Dec 21, 2021 at 12:18 PM Simon Sobisch @.***> wrote:
Thank you for the report.
Do you see the variables in the outline (so the extension in general does recognize them)? Is your workspace marked as "trusted" (so all extensions are fully loaded)?
I am not sure when it stopped working.
Can you please check the easy way with going to the extension view, then select the gear wheel and then "install different version"?
— Reply to this email directly, view it on GitHub https://github.com/spgennard/vscode_cobol/issues/310#issuecomment-998994910, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC7BEWPYATK5IZTJAUU5KBLUSDAHBANCNFSM5KQM2G3A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID: @.***>
-- Thanks,
Andy Crofford
spgennard
commented
2 years ago @andycrofford - This extension provides context-based suggestions, so without a context.. ie: the user of a verb, then it did not return any suggestions but left it to the vscode "text" based suggestions support.
Text-based suggestions give themselves away by the "abc" before the suggested word.
It looks like vscode now only provides text-based suggestions to plain text files, so I added a coboleditor.coboleditor.suggest_variables_when_context_is_unknown property, which currently defaults to true (but may changed if it becomes problematic), so please try v7.12.20
@andycrofford - Sorry if @GitMensch caused you extra work rather attempting to reproduce it, himself
GitMensch
commented
2 years ago Hm, I'm currently using the last bitlang.gnucobol and vscode 1.63.2 and I still get the text based suggestions in files with that langId. So I think vscode is possibly not to blame.
From the vscode change log: previously texts were only presented for auto-complete after every provider added his suggestsions, now it is presented as soon as the first one (for completions commonly the text based suggestions) returns its list, which is then extended each time another provider returns its list.
spgennard
commented
2 years ago No surprise because it is different because it has different providers and based on a different level of vscode.
On Tue, 21 Dec 2021, 19:35 Simon Sobisch, @.***> wrote:
Hm, I'm currently using the last bitlang.gnucobol and vscode 1.63.2 and I still get the text based suggestions in files with that langId. So I think vscode is possibly not to blame.
From the vscode change log: previously texts were only presented for auto-complete after every provider added his suggestsions, now it is presented as soon as the first one (for completions commonly the text based suggestions) returns its list, which is then extended each time another provider returns its list.
— Reply to this email directly, view it on GitHub https://github.com/spgennard/vscode_cobol/issues/310#issuecomment-999041806, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNWWGDRKG2GLKSET2HK5ILUSDJJRANCNFSM5KQM2G3A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID: @.***>
spgennard
commented
2 years ago Simon, can I kindly remind you this extension has nothing to do with the gnucobol extension.
It's a different code base with different features, so please don't mention it here (ever).
On Tue, 21 Dec 2021, 19:35 Simon Sobisch, @.***> wrote:
Hm, I'm currently using the last bitlang.gnucobol and vscode 1.63.2 and I still get the text based suggestions in files with that langId. So I think vscode is possibly not to blame.
From the vscode change log: previously texts were only presented for auto-complete after every provider added his suggestsions, now it is presented as soon as the first one (for completions commonly the text based suggestions) returns its list, which is then extended each time another provider returns its list.
— Reply to this email directly, view it on GitHub https://github.com/spgennard/vscode_cobol/issues/310#issuecomment-999041806, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNWWGDRKG2GLKSET2HK5ILUSDJJRANCNFSM5KQM2G3A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID: @.***>
andycrofford
commented
2 years ago It is now working as expected with the newest version. Thank you very much for this extension and your support.
Andy
On Tue, Dec 21, 2021 at 2:03 PM spgennard @.***> wrote:
Simon, can I kindly remind you this extension has nothing to do with the gnucobol extension.
It's a different code base with different features, so please don't mention it here (ever).
On Tue, 21 Dec 2021, 19:35 Simon Sobisch, @.***> wrote:
Hm, I'm currently using the last bitlang.gnucobol and vscode 1.63.2 and I still get the text based suggestions in files with that langId. So I think vscode is possibly not to blame.
From the vscode change log: previously texts were only presented for auto-complete after every provider added his suggestsions, now it is presented as soon as the first one (for completions commonly the text based suggestions) returns its list, which is then extended each time another provider returns its list.
— Reply to this email directly, view it on GitHub < https://github.com/spgennard/vscode_cobol/issues/310#issuecomment-999041806 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABNWWGDRKG2GLKSET2HK5ILUSDJJRANCNFSM5KQM2G3A
. Triage notifications on the go with GitHub Mobile for iOS < https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
You are receiving this because you commented.Message ID: @.***>
— Reply to this email directly, view it on GitHub https://github.com/spgennard/vscode_cobol/issues/310#issuecomment-999059135, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC7BEWLCX57OW2I2E7DHNYLUSDMSVANCNFSM5KQM2G3A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID: @.***>
-- Thanks,
Andy Crofford
spgennard
commented
2 years ago @andycrofford - Thanks for the feedback and Happy and healthy holidays
Describe the bug No longer pops up suggestions for variable names in working storage.
To Reproduce Steps to reproduce the behavior:
Expected behavior A list of suggested variable names used to pop up when you started typing one.
Desktop (please complete the following information):
Additional context I am not sure when it stopped working.