spgennard / vscode_cobol

Visual Studio Code Extension for COBOL, JCL and MF Directive Files
MIT License
36 stars 16 forks source link

[support] navigation with SQL cursors #340

Closed Evileoo closed 2 weeks ago

Evileoo commented 3 weeks ago

Currently, this is not possible to see cursor declaration and references

Could it be possible to identify it as a variable ? It would be awesome if we can move thru cursor calls

image image

spgennard commented 3 weeks ago

I think this is a reasonable request, let me have a think about the best way I can do it.

spgennard commented 2 weeks ago

Please try out version 10.8.28

Evileoo commented 2 weeks ago

Okay

Go to / peek definition works But Go to / peek references doesn't

It is still a bit easier to navigate thanks

Evileoo commented 2 weeks ago

this feature broke with the update https://github.com/spgennard/vscode_cobol/issues/333

spgennard commented 2 weeks ago

Thanks, i will look at it tonight.

Peek references are present but hoverover peek is not

spgennard commented 2 weeks ago

If you get a chance, update and you should fine it has changed.

Evileoo commented 2 weeks ago

Yep it got fix, thanks

spgennard commented 2 weeks ago

So, are you a happy camper?

(Rename support in the pipeline)

Evileoo commented 2 weeks ago

Tell me if I'm wrong We can only see cursor DECLARE and FETCH right ? It didn't seem to work on OPEN and CLOSE

spgennard commented 2 weeks ago

It should be okay, can you provide an example (does not have to compile, so you remove anything important to you)

Evileoo commented 2 weeks ago

Okay it works in my example but doesn't in the code I'm searching for the bug

Evileoo commented 5 days ago

Sorry for the long waiting time.

I found out the bug doesn't come directly from your extension. I copied a program with the bug in a new file to remove some parts and see what breaks the feature. Surprsingly, it worked without removing any part...

I am still searching why it doesn't work in the original file.

Thanks for everything, Léo

spgennard commented 5 days ago

Okay, thanks