search

sphair / ClanLib

ClanLib is a cross platform C++ toolkit library.
Other
344 stars 76 forks source link

Refactor DirectoryScanner_Unix::scan #110

Closed bmwiedemann closed 5 years ago

bmwiedemann commented 5 years ago

Refactor DirectoryScanner_Unix::scan to reduce code duplication

This is going to serve as a base for reworking the next method to not vary from filesystem readdir order.

Note: only slightly tested.

This PR was done while working on reproducible builds for openSUSE.

bmwiedemann commented 5 years ago

I think, I will defer further patches, because the clanlib-doc that was unreproducible in our clanlib-2.3.6 is building reproducibly with git master and there are not many users around anyway. 'methane' was the only one I found and it is also fine.