Request and Response types - Githubissues

sphaso / firebase-haskell-client

BSD 3-Clause "New" or "Revised" License

0 stars 0 forks source link

Request and Response types #1

Closed sphaso closed 8 years ago

sphaso commented 8 years ago

Regarding Request:

we might want to wrap Firebase options (shallow, debug etc.) in a FirebaseRequest type which is then disassembled and fed to the wreq function
there is also a concern about wreq's post function. The post payload has a typeclass of "Postable". I would think it would be better to have the user give a JSON string which we would then parse and transform into a Postable data type

Regarding Response:

I think the absolute minimum requirement would be to return the response body and the status code
there is also a use case for the return of a particular header. When the user specifies "debug", additional information is stored in the "X-Firebase-Auth-Debug" response header
should we return every header just in case?

sphaso commented 8 years ago

Return all headers

sphaso commented 8 years ago

Now FireResponse returns all headers [Header]. Reopen if there's any issue.