search

spheenik / clarity-analyzer

JavaFX-Application to interactively visualize the raw data of a Dota 2, CSGO, CS2 or Deadlock replay.
BSD 3-Clause "New" or "Revised" License
49 stars 19 forks source link

Build error #9

Closed vbashiri closed 5 years ago

vbashiri commented 5 years ago

I build clarity-analyzer on mac with java 1.8.0_201 and maven 3.6.1.

the errors are

Error:(29,57) java: cannot find symbol

wich is for

List<FieldPath> fieldPaths = entity.getDtClass().collectFieldPaths(entity.getState());

collectFieldPaths cannot be resolved.

and

Error:(54,27) java: no suitable method found for binarySearch(java.util.List,skadistats.clarity.model.FieldPath)

which is for line

public int getIndexForFieldPath(FieldPath fieldPath) { return Collections.binarySearch(indices, fieldPath); }

sorry if I miss anything, I am new. :D

spheenik commented 5 years ago

Hmm, I probably forgot to deploy a new snapshot for clarity 2.5. I just did. Can you try again?

Oibaf94 commented 5 years ago

hi, i tried building this on windows 10 with java 1.8.0_131 and maven 3.6.2 and i get these same 2 errors

Screenshot_1

spheenik commented 5 years ago

Forgot to push some commits. Sorry. Should work now.

Oibaf94 commented 5 years ago

actually i still get the same exact errors. i'm not sure if i'm missing something tbh. I managed to make the project compile by commenting out every line that was giving errors, but then when i go into a replay i get empty tables for every entity so it obviously breaks something important. was i supposed to actually do something to get those commits you pushed? asking cause i'm not too familiar with how github works, sorry for the trouble

spheenik commented 5 years ago

You got to pull the changes, did you?

Oibaf94 commented 5 years ago

the changes i made on my end to make it compile break the whole thing so no point to request a pull. actually i think its possible that the commits you pushed didn't go trough/didn't update? I tried going here https://oss.sonatype.org/content/repositories/snapshots/com/skadistats/clarity/2.5-SNAPSHOT/ and the last change to clarity-2.5-20190904.064646-5.jar where my compiler says the issue is is from the 4th of september.

I also couldn't find the collectFieldPaths method anywhere in EntityState.class which i assume is where it's supposed to be?

I'm not that good of a programmer so i'm kinda taking a shot in the dark, i'd try to fix it myself but i have no clue on earth how to do that. sorry again for taking your time

spheenik commented 5 years ago

No, you misunderstood. I do not want a pull request, I want you to pull the changes I made to clarity-analyzer this morning. Just erase the repo and clone again if you do not know how.

Oibaf94 commented 5 years ago

oh, yeah sorry, it works now. I thought that since in the github page it showed no recent update that there wasn't any change from what i cloned just yesterday. Thanks a lot, amazing work

vbashiri commented 5 years ago

I pull the changes and now everything works perfectly. Just another question, Is there any way to turn on fog of war? Is such a data send by server in the first place or does the clarity parse these kinds of information?

and thank you for your great work, feel free to close the issue.

spheenik commented 5 years ago

The replay is written from the server's perspective, so it contains all entities per se. There is a flag on every entity (something named "visibleByTeam" or so), which you could use. The actual fog information, for example obstruction from trees etc. is not encoded in the replay, but calculated by the client in real time.

vbashiri commented 5 years ago

thank you very much. :7