spheras / desktopfolder

Bring your Desktop Back to Life
GNU General Public License v3.0
202 stars 41 forks source link

Drag and Drop within Home folders should move #254

Open fossfreedom opened 5 years ago

fossfreedom commented 5 years ago

Enhancement request for desktopfolder v +1 ... or v +2.

Testing out the new auto drag drop mechanism I did note something that I've been meaning to query for a while - this probably falls into the previous discussion where drag and drop probably needs a relook at anyway - or it could fall under the copy paste mechanism previously discussed between file-managers and desktopfolder.

Within a file-manager if you drag and drop files to folders that are in your Home folder or a sub-folder, the file is moved.

Within a file-manager if you CTRL + drag and drop files to folders that are in your Home folder or a sub-folder, the file is copied.

With a file-manager if you drag and drop files to folders that are not in your Home folder or a sub-folder, the file is copied.

With a file-manager if you SHIFT + drag and drop files to folders that are not in your Home folder or a sub-folder, the file is moved.

With desktop-folder - if you drag and drop to a panel on the desktop - yes correctly moves.

With desktop-folder - if you CTRL + drag and drop to a panel on the desktop - yes correctly copies

With desktop-folder - if you drag and drop to a home folder on your file-manager, the file should be moved - not copied.

spheras commented 5 years ago

So, what is wrong is only the last part you described (pls, correct me if I'm wrong)

"With desktop-folder - if you drag and drop to a home folder on your file-manager, the file should be moved - not copied."

The behaviour described, in elementary os is different. When I drag and drop to a home folder on elementary Files, the file is moved. I tried on Budgie, and is true, it is copied.

@fossfreedom, I'm not completely sure (not too much experience with GTK), but If I'm not wrong the behavior (copy/move/link) on the destination, and the dependency with the keys pressed (ctrl, shift,..) is something that depends on the destination. For instance, when something is dropped (and moved, to select the cursor icon) onto desktopfolder, I decide what to do with the file (move/copy) depending on the keys pressed. Do you know If I'm wrong?

fossfreedom commented 5 years ago

CTRL + drag and drop signifies a copy operation SHIFT + drag and drop signifies a move operation

So when you press CTRL and drag the cursor changes to a hand-grab with a + symbol to indicate a copy So when you press SHIFT and drag the cursor changes to a hand-grab with a bottom-left-up arrow symbol to indicate a move

If you just Drag in a file-manager you see initially the same "SHIFT" cursor observation (i.e. a move by default) - the cursor changes when on a hover over a folder that is NOT a home folder - at that point it changes to a grab hand + symbol to indicate a copy.

Pressing CTRL or SHIFT overrides the destination move/copy destination decision above - i.e. forces a copy or forces a move respectively.