Fix compilation issues with vala 0.44

spheras / desktopfolder

Bring your Desktop Back to Life

GNU General Public License v3.0

200 stars 40 forks source link

Fix compilation issues with vala 0.44 #259

Closed fossfreedom closed 5 years ago

fossfreedom commented 5 years ago

Disco (proposed) has upgraded to vala 0.44 and desktopfolder v1.0.10 no longer builds

Ubuntu Devs have created a patch for that particular version to get it to build under vala 0.44.

This PR is based on that patch rebased for v1.1.0.

So this resolves the compilation issues.

However - important - this just gets the compilation working. I'm unsure that the changes meet the intention of what the code was originally doing, so please review carefully and advise.

spheras commented 5 years ago

ups, yeah, I understand. Are these changes retro-compatible? I will merge and check if the behavior is still the same. Thanks @fossfreedom!

spheras commented 5 years ago

Everything is working fine. The changes seem to be correct. I have some minor doubts (mainly because I don't have too much experience in vala) about the changes but seems perfect. Also, those changes seem to maintain backward compatibility... so, OK.