search

spheras / desktopfolder

Bring your Desktop Back to Life
GNU General Public License v3.0
202 stars 41 forks source link

Locked panels could be deleted! #286

Open saidbakr opened 4 years ago

saidbakr commented 4 years ago

Description

When a panel is set to be Locked, the user able to delete it using the trash icon appeared on its title bar.

Steps to reproduce

  1. Create a panel on the desktop.
  2. Go to the panel properties.
  3. Activate the Lock panel property under Behavior .
  4. Press Close button.
  5. Mouse over the panel title. The trash icon of delete the panel is appeared.
  6. Move the cursor towards the trash icon and left click over it.

Expected result

In step 5, the trash icon should not be shown, because the panel has been locked and Lock property should protect it from delete beside move.

Actual result

The panel is deleted.

System Information

Djcoper commented 4 years ago

@saidbakr Locking a panel Prevents it from being moved not deleted and so the program is producing expected behaviour in your case. If you want the ability to prevent deleting then you can file an feature request.

saidbakr commented 4 years ago

@saidbakr Locking a panel Prevents it from being moved not deleted and so the program is producing expected behaviour in your case. If you want the ability to prevent deleting then you can file an feature request.

Lock means lock! Like we found in KDE desktop widgets for example. Logically, move to trash is a kind of moving!

spheras commented 4 years ago

Thanks @saidbakr for reporting. As @Djcoper comments, locking in desktopfolders just means you can't move the panel. I will tag this as a feature request, As this seem to be a new feature added to the current lock functionality. I would like to collect some users feedback on this proposal behavioral feature associated with the lock funciontality. If they feel it is interesting or not.

fossfreedom commented 4 years ago

Lock icons and Lock panels I guess could be slightly confusing when coming from other environments. I would be interested to know if KDE and others use the phrase "Pin" i.e. pin to the desktop to make the 'widget' not moveable.

saidbakr commented 4 years ago

Thanks @saidbakr for reporting. As @Djcoper comments, locking in desktopfolders just means you can't move the panel. I will tag this as a feature request, As this seem to be a new feature added to the current lock functionality. I would like to collect some users feedback on this proposal behavioral feature associated with the lock funciontality. If they feel it is interesting or not.

Here, I'm about a logical concept. Lock means protection. Moving to trash is a kind of move too. Additionally, if possible too, the deleted panel should be found in the trash and the user should be able to restore it if he/she mistakenly deleted it.