search

spheras / desktopfolder

Bring your Desktop Back to Life
GNU General Public License v3.0
202 stars 41 forks source link

Fix the bug of blacked wallpaper on some Linux distros. #308

Closed mmoneib closed 4 years ago

mmoneib commented 4 years ago

This is a proposed fix for issue #297 . The wallpaper is shown as black seemingly due to an underlying element on top of the wallpaper itself. I didn't go through debugging how come this element exists and wasn't styled -- it doesn't look like there should be an element from the code in the first place -- and since the issue only affects certain distros, I thought a styling workaround would be a good approach.

In short, the styling workaround forces transparency on any descendant of a transparent folder if it doesn't have a styled background.

I tested on my machine, Fedora 32, and the fix looks fine.

spheras commented 4 years ago

Great @mmoneib! I have been checking in elementary, and it seems the changes have not any not desirable side effect. I'm merging it. Thak you very much!

kerroncheddie commented 4 years ago

Sorry for the late update, the change has solved the problem on debian SID, gnome-flashback. Thank you for this amazing program.