Closed emmenko closed 9 years ago
I think we should only use on project, I sent you the credentials.
Why not put each language specific example into its own repository? This repo could just link to other repos. This would make build process simpler and easier to understand for visitors looking for particular examples.
Looks list a complete demo shop now, instead of hello world application :)
@OlegIlyenko I wanted to provide a practical example and use-case where people can start with instead of the classical useless 3 lines example. I could have just use a single file like this
// hello.js
var config = {
project_key: 'PROJECT_KEY',
client_id: 'CLIENT_ID',
client_secret: 'CLIENT_SECRET'
}
var client = new require('sphere-node-sdk').SphereClient({config: config})
client.products.fetch().then(function(result){
console.log(result)
})
But you can't practically start anything with this. I find it useful to have a basic starting point.
@butenkor makes sense yes. I opened a ticket https://github.com/sphereio/sphere-hello-api/issues/20
@emmenko i find the example you implemented very good, so we definitely need to keep it. But I think that we also need extra one small 3 line example - just a trivial hello world (at least i though that it's the purpose of this repo to contain such examples)
I agree with @OlegIlyenko .
I will provide then also a simple example then :+1:
cool, thanks a lot!
I made three pull requests where the projects root directory was saved into
projects_dir
and I only ran one config script for all projects. I think this should be uniform.https://github.com/sphereio/sphere-hello-api/pull/18/files#diff-354f30a63fb0907d4ad57269548329e3R3