search

sphereio / sphere-hello-api

First steps to access the API of SPHERE.IO in several languages
http://sphere.io
MIT License
24 stars 11 forks source link

Print the generated access token #42

Closed Siilwyn closed 8 years ago

Siilwyn commented 8 years ago

Instead of printing just a message that it is created actually print the generated access token to clarify it worked.

adnasa commented 8 years ago

👍

schleichardt commented 8 years ago

I am not sure if we should expose our credentials.

Siilwyn commented 8 years ago

Good point but even without printing, the initial command contains all data needed to get the access token. Also the token gets written to a file by default.

Otherwise I would replace the colon with a dot to make it clearer.

Siilwyn commented 8 years ago

More thoughts on this @schleichardt? The command itself contains all needed information to get the token so I don't see any harm into printing it, especially not since the output won't be saved in the bash history. Looking to either close or merge this old PR. :)

hajoeichler commented 8 years ago

I just checked the travis output. It of course contains the token. But the log does not contain the project key nor any other information. So I am fine with that. See build https://travis-ci.org/sphereio/sphere-hello-api/builds/157576826