search

spherical-volume-rendering / svr-algorithm

A spherical volume rendering algorithm that performs ray casting through a spherical voxel grid.
Other
6 stars 7 forks source link

Add Chord length Test #100

Closed nukenukenukelol closed 4 years ago

nukenukenukelol commented 4 years ago

Add chord length test to the spherical case. The logic is similar to the polar one. We first find the expected chord length via the entry and exit time calculation. Then, we use an accumulator to keep track of total time we spend on traversal.

cgyurgyik commented 4 years ago

I'm sorry, I'm still a bit lost on this. How would I actually write a unit test using this? Is there any way to add chord length tests to our testing .m file?

ak-2485 commented 4 years ago

@cgyurgyik our function could output [rVoxels, thetaVoxels, phiVoxels, traversal time] and we could then have a verification on this value where the expected value is calculated externally in a different function.

ak-2485 commented 4 years ago

@nukenukenukelol @cgyurgyik after you review the PR #103 can @nukenukenukelol migrate the above into the new code?

nukenukenukelol commented 4 years ago

@nukenukenukelol @cgyurgyik after you review the PR #103 can @nukenukenukelol migrate the above into the new code?

Yes will do