search

sphericalpm / lektorium

A pragmatic web content management solution for those with way too many little sites
MIT License
16 stars 3 forks source link

IARCRP-209: permission dialog updates #71

Closed apatrushev closed 4 years ago

codecov[bot] commented 4 years ago

Codecov Report

Merging #71 into dm-iarcrp-88 will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           dm-iarcrp-88      #71   +/-   ##
=============================================
  Coverage         83.67%   83.67%           
=============================================
  Files                32       32           
  Lines              2475     2475           
=============================================
  Hits               2071     2071           
  Misses              404      404

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5efc443...5efc443. Read the comment docs.

dmitriiminaev commented 4 years ago

PR changes look OK, but I can't understand why selectedUserPermissions is not a computed value

apatrushev commented 4 years ago

PR changes look OK, but I can't understand why selectedUserPermissions is not a computed value

It is very old vue code when we was not so experienced in vue.