spheronFdn / beta-testing

🐛 Report all the bug found during beta testing
4 stars 3 forks source link

Bug: Auto creation of separate environments based on branches #25

Open tinybigideas opened 2 years ago

tinybigideas commented 2 years ago

Describe the bug

Deployment environments are automatically created without input from the user.

Criticality

Low? Depends if it wastes account quotas

To Reproduce

Steps to reproduce the behavior:

  1. Add repo with multiple branches
  2. Go to Settings > Deployment Environments
  3. See error

Expected behavior

If there are multiple branches, user should be asked which environments they wish to create rather than automatically assume. Especially if these other branches are unknowingly being tracked and deploying on changes. User may be wasting their quota on dev branches without realising.

Screenshots

image

For some reason, it picked up a dependabot branch as "Development". You can see how I wouldn't want that.

Seemingly selected all the dependabot branches:

image

Your Details

rekpero commented 2 years ago

Our development CD pipeline adds all the branches so that whenever you commit anything on any branch it will automatically trigger a deployment for your project. The dependabot branches might be a bit of a nuisance, it doesn't cause any harm to your project in any way.

Tho we need to work on UI for the branch multi-select option. Also, these 2 environments are free and if you need more, you can always deactivate one and add another custom environment or pay 5 USD to add another one for your project.

Thanks for reporting @tinybigideas

tinybigideas commented 2 years ago

@rekpero I would argue that is a UX issue as it could worry a user that their usage is inflated by random (potentially unused) branches getting deployed. Should dependabot create a new branch (potentially many, every month) it'll propagate and deploy them?