search

sphincs / sphincsplus

The SPHINCS+ reference code, accompanying the submission to NIST's Post-Quantum Cryptography project
https://sphincs.org
Other
131 stars 44 forks source link

Add shake256-a64 implementation #24

Closed bwesterb closed 2 years ago

bwesterb commented 2 years ago

Uses the optional SHA3 extension on Armv8.2-A.

kste commented 2 years ago

This is great :-). Can we add this implementation also to the CI checks?

bwesterb commented 2 years ago

This is great :-). Can we add this implementation also to the CI checks?

Github Actions doesn't have ARM runners. We could emulate with qemu, but we'd have to check whether that stays within the runtime limits. I propose to create an issue for that once this is merged.

kste commented 2 years ago

Sounds good to me. Did you by any chance manually check whether we get the same test vectors?

bwesterb commented 2 years ago

Sounds good to me. Did you by any chance manually check whether we get the same test vectors?

Yes, I did: they all match.