sphincs / sphincsplus

The SPHINCS+ reference code, accompanying the submission to NIST's Post-Quantum Cryptography project
https://sphincs.org
Other
131 stars 44 forks source link

Enable -Wconversion in `ref` #39

Closed thomwiggers closed 2 years ago

thomwiggers commented 2 years ago

This PR enables -Wconversion. This warning makes you do lots of casts more explicitly than strictly necessary; e.g. truncation is defined in the standard. However, Microsoft compilers are a lot more picky about this, so this prepares for that.

Going through these files also produced a bunch of trailing-whitespace-eating; sorry for that noise but I thought it was better to just include it.

I haven't had time to touch the accelerated implementations yet; I'm currently still fighting with the other things necessary to integrate ref into PQClean.

bwesterb commented 2 years ago

Thanks Thom.