sphinx-contrib / confluencebuilder

Confluence Markup Builder Plugin for Sphinx
BSD 2-Clause "Simplified" License
315 stars 99 forks source link

Incompatibility with sphinx-toolbox 3.8.0 #1029

Closed adamtheturtle closed 1 month ago

adamtheturtle commented 1 month ago

When building my docs with the new sphinx-toolbox I see:

sphinxcontrib/confluencebuilder/transmute/ext_sphinx_toolbox.py", line 85, in replace_sphinx_toolbox_nodes
    new_node.attributes['title'] = node.label
                                   ^^^^^^^^^^
AttributeError: 'CollapseNode' object has no attribute 'label'

I believe that this is due to https://github.com/sphinx-toolbox/sphinx-toolbox/commit/ae0ae836268a8e77e36ce58e534131e9ac42a75d.

I can make a minimal reproduction if needed.

jdknight commented 1 month ago

Should be handled via https://github.com/sphinx-contrib/confluencebuilder/pull/1030.

Feel free to try it out and report any issues.

jdknight commented 1 month ago

v2.7 is now available on PyPI -- marking as closed.

adamtheturtle commented 1 month ago

Thank you!