Open Paldari opened 2 hours ago
I can propose a small Pull Request to fix this, later today or tomorrow (tested only locally so far).
But I'm wondering if a better long term fix wouldn't be to rely on Sphinx utilities for that sort of path manipulation.
For instance: env.relfn2path(...) It would require some more changes though...
Hello,
Issue (regression) appearing from confluencebuilder 2.5
Issue description
After updating confluencebuilder from version 2.4 to 2.8 (yeah, it's been a long time...) we started to get issues with
:download:
role when using an absolute path (absolute in the sense of Sphinx, i.e. the root is actually the repository root dir -env.srcdir- not the system root).Note: It is still working fine with the HTML Builder.
Small example with a downloadable file located in a sphinx repo at: migrated-static/files/myppt.ppt
We get some logs like these (verbose only):
And a WARNING at the end:
Could you please restore this functionnality and support these pseudo-absolute path?
Investigation
Regression seems to come from this commit in
utils.py
file: Commit 336725cMore specifically:
normalized_path.name
returns the last part of the path (name of the file) while this check was initially supposed to check the first char of the whole file path.Report