search

sphinx-contrib / emojicodes

An extension to use emoji codes in your Sphinx documentation! 😍
https://sphinxemojicodes.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
50 stars 15 forks source link

Improve docs #12

Closed honzajavorek closed 4 years ago

honzajavorek commented 4 years ago

While working on https://github.com/sphinx-contrib/emojicodes/issues/11 I spotted there's something wrong with the gay pride flag (it displayed to me as two characters - rainbow and the white flag), so I overwrote it with whatever the Apple's character map has produced for me. Now it displayes correctly on my computer.

image
Peque commented 4 years ago

@honzajavorek I uploaded a new version of the package. I added a new source for emoji codes and this new source fixes some emojis including, I believe, the gay pride flag emoji. Have a look at it and report back if you find any issues.

honzajavorek commented 4 years ago

Thanks for the heads up! I will. I’m sorry this takes me time, but it’s low priority cobtribution for me. Nevertheless, I plan to get back to it and thanks for the review, good points :)

On Sat, 4 Apr 2020 at 22:11, Miguel Sánchez de León Peque < notifications@github.com> wrote:

@honzajavorek https://github.com/honzajavorek I uploaded a new version of the package. I added a new source for emoji codes and this new source fixes some emojis including, I believe, the gay pride flag emoji. Have a look at it and report back if you find any issues.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/sphinx-contrib/emojicodes/pull/12#issuecomment-609082867, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACFGMK3IALUDO4YNRKLNR3RK6H5VANCNFSM4LQ7S3CA .

honzajavorek commented 4 years ago

I updated the PR, thanks for all the suggestions!

Peque commented 4 years ago

@honzajavorek Thanks for the contribution! :heart: