Port to sphinx 2.x

[jonascj]

So how do we proceed from here? Should we ask for admin privileges to be able to merge?

[dhellmann]

@jonascj I've made you an admin (or at least invited you to be). I'll leave it up to you to decide who else to add to the repo. Use your powers for good. ;-)

[t-b]

@jonascj Merge?

[jonascj]

Sorry, email notifications were turned off. Give me a day or two to read up on the status of things. But yes, I guess so.

[spinus]

This patch looks really good. Cheers.

[m1no]

PR looks good for me too. @jonascj thanks for taking over the maintainer here.

[rixx]

For everybody else waiting for this PR, this is the line to use it directly in your requirements.txt or with pip:

git+https://github.com/t-b/sphinxcontrib-images@port-to-sphinx-2.x

[jonascj]

I'm not sure I ever intended to become the maintainer... I would like to, but I need some help moving forward.

Any preferences on merge commit vs. squash+merge vs. rebase+merge?

Can we skip further reviews? It passes the Travis-build for various versions, so to me everything seems good.

[t-b]

My preference is merge commit. I'm okay with merging as is.

Do you have the credentials for https://pypi.org/ for uploading a new package version?

[jonascj]

I don't think we ever got the pypi.org creddentials from @spinus .

Do we wish to use https://pypi.org/project/sphinxcontrib-images/ going forward? Or is there another better package name now under the sphinx-contrib/images umbrella?

[t-b]

If possible I would favour using the existing package name in order to make it hassle-free for the user.

[jonascj]

I went back through the old PR conversations and e-mails. Privileges on https://pypi.org/project/sphinxcontrib-images/ were never transferred or credentials shared. I've contacted @spinus about this.

The old conversations revealed that the package was prepared manually and manually uploaded to pypi.org. I'll do that again once I have access.

[spinus]

done. Let me know if I should add anyone else. Cheers