search

sphinx-contrib / images

sphinxcontrib-images extension
Apache License 2.0
17 stars 14 forks source link

Fix #8: Incremental building not working #18

Closed terencehonles closed 3 years ago

terencehonles commented 3 years ago

This incorporates my suggestions in #14 and is just a PR to make https://github.com/sphinx-contrib/images/pull/14#issuecomment-677893918 easier

jonascj commented 3 years ago

Let me see if I can get this reviewed and tested this coming weekend (9th, 10th January). Thank you for moving it forward @terencehonles

See also #20 :-)

jonascj commented 3 years ago

@terencehonles I've reviewed your changes and asked you (or just aloud) a few questions.

I can't shake the feeling that somewhere along the way someone just updated the config dictionary wrong (got the copy semantics wrong, maybe that is why there were a few globals). So I'll see if I can get something in between your suggestions and @kujiu's suggestion to work.

Also, we have a Travis build problem at the moment, see https://github.com/sphinx-contrib/github-administration/issues/15. I'd like that resolved before I release a new version of the package (I do not have all the many Python version and implementations installed locally, so I can't run all the tests locally).

EDIT: can to can't

jonascj commented 3 years ago

@terencehonles Today the Travis support team responded, after a 3 months wait, that they've allocated me some open source build-time (they did apologize for the wait though).

So builds are running again at Travis and I'll get back on this PR (during next week).

terencehonles commented 3 years ago

Sounds good. I haven't had time to look at this in awhile (more it wasn't high enough for the free time I had). I'll make sure the PR is up to date (so thanks for the ping) and I may be able to see about suggesting a PR for GitHub actions which has become a lot more popular lately

terencehonles commented 3 years ago

I responded to your comments and changed the name of the function as requested.

SilverRainZ commented 3 years ago

Does this PR actually fix #8?

I am using sphinx 4.0.2 with sphinxcontrib-image 0.9.3, and it always say 'config changed':

Running Sphinx v4.0.2
loading translations [zh_CN]... done
loading pickled environment... done
Initiated sphinxcontrib-images backend: `sphinxcontrib_images_lightbox2.lightbox2:LightBox2`
building [mo]: targets for 0 po files that are out of date
building [html]: targets for 0 source files that are out of date
updating environment: [config changed ('images_config')] 124 added, 10 changed, 0 removed
terencehonles commented 3 years ago

Replied in #8, and let's try to keep the discussion in one place

terencehonles commented 3 years ago

sorry I had too many tabs open and looks like I put it on the wrong one :facepalm: it's fixed now