search

sphinx-contrib / images

sphinxcontrib-images extension
Apache License 2.0
19 stars 16 forks source link

Use non-deprecated alias for util.status_iterator #39

Open j9ac9k opened 1 year ago

j9ac9k commented 1 year ago

sphinx.util.status_iterator alias has been deprecated since sphinx 6.1 and will be removed in sphinx 8.0

See https://www.sphinx-doc.org/en/master/extdev/deprecated.html

The preferred access for status_iterator is sphinx.util.display.status_iterator. This commit adopts the new sphinx API and then falls back on the older API access since this plugin supports older versions of sphinx.

SiboVG commented 5 months ago

@jonascj this looks like a good change, could you merge this PR?

jonascj commented 5 months ago

Sure, I'll have a look at it one of the coming days. The package needs a new release and have for some time https://github.com/sphinx-contrib/images/issues/33 .

aiudirog commented 3 months ago

It looks like Sphinx 8.0 did indeed remove the deprecated alias: https://www.sphinx-doc.org/en/master/changes.html#release-8-0-0-released-jul-29-2024

jonascj commented 3 months ago

How days turns to weeks ...

I've outlined the tasks which needs completion to do a new release, this is obviously on the todo-list since it is required for newer Sphinx versions: https://github.com/sphinx-contrib/images/issues/40

Hadrien45 commented 3 weeks ago

I've got the same problem with Sphinx 8, this code fix it.
Do you know when this PR can be merged ?