Fix autodoc parsing error when source matlab file is not encoded as UTF-8

sphinx-contrib / matlabdomain

A Sphinx extension for documenting Matlab code

http://sphinxcontrib-matlabdomain.readthedocs.io/

Other

70 stars 45 forks source link

Fix autodoc parsing error when source matlab file is not encoded as UTF-8 #92

Closed ptitrex closed 5 years ago

ptitrex commented 5 years ago

Hi !

I tried using your tool for our projects and I had some problems for non UTF-8 files (parser would crash on autodoc parsing). I made the following changes to handle it :

Added default behavior to replace errors with ? chars
Added sphinx configuration to choose parsing encoding (default = UTF-8)

I added the corresponding unit test and documentation. Please tell me if you have any remarks regarding this pull request.

joeced commented 5 years ago

Very nice addition.