sphinx-contrib / plantuml

BSD 2-Clause "Simplified" License
115 stars 42 forks source link

Add pyproject.toml file #75

Closed gusthoff closed 1 year ago

gusthoff commented 1 year ago

I've got the following warning from pip:

DEPRECATION: sphinxcontrib-plantuml is being installed using the legacy 'setup.py install' method, because it does not have a 'pyproject.toml' and the 'wheel' package is not installed. pip 23.1 will enforce this behaviour change. A possible replacement is to enable the '--use-pep517' option. Discussion can be found at https://github.com/pypa/pip/issues/8559

This issue could be solved by adding a pyproject.toml file.

yuja commented 1 year ago

Can you check if https://github.com/sphinx-contrib/plantuml/pull/76 fixes the problem?

gusthoff commented 1 year ago

Sorry for the delay!

I've just checked your change, and it seems to be working fine. To be more precise, I replaced this line:

sphinxcontrib-plantuml==0.25

with this one:

git+https://github.com/sphinx-contrib/plantuml.git@4e573e1b0a947bba929a5061f583986890f7d712

This time, I didn't get any warnings when updating the packages. This was the actual output:

Collecting git+https://github.com/sphinx-contrib/plantuml.git@4e573e1b0a947bba929a5061f583986890f7d712 (from -r /vagrant/frontend/requirements.txt (line 18))
  Cloning https://github.com/sphinx-contrib/plantuml.git (to revision 4e573e1b0a947bba929a5061f583986890f7d712) to /tmp/pip-req-build-ui09eswo
  Running command git clone --filter=blob:none --quiet https://github.com/sphinx-contrib/plantuml.git /tmp/pip-req-build-ui09eswo
  Running command git rev-parse -q --verify 'sha^4e573e1b0a947bba929a5061f583986890f7d712'
  Running command git fetch -q https://github.com/sphinx-contrib/plantuml.git 4e573e1b0a947bba929a5061f583986890f7d712
  Running command git checkout -q 4e573e1b0a947bba929a5061f583986890f7d712
  Resolved https://github.com/sphinx-contrib/plantuml.git to commit 4e573e1b0a947bba929a5061f583986890f7d712
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... done

Building wheels for collected packages: sphinxcontrib-plantuml
  Building wheel for sphinxcontrib-plantuml (pyproject.toml) ... done
  Created wheel for sphinxcontrib-plantuml: filename=sphinxcontrib_plantuml-0.25-py3-none-any.whl size=11216 sha256=515242af2bbacce8c25304da2e2992e54fed867d39d4d5a835c2495cabacb3a3
  Stored in directory: /root/.cache/pip/wheels/62/60/d2/13fe52e13fe419c31333155acd718e2c33f4228d26d3871c53
Successfully built sphinxcontrib-plantuml
Installing collected packages: sphinxcontrib-plantuml
  Attempting uninstall: sphinxcontrib-plantuml
    Found existing installation: sphinxcontrib-plantuml 0.24
    Uninstalling sphinxcontrib-plantuml-0.24:
      Successfully uninstalled sphinxcontrib-plantuml-0.24
Successfully installed sphinxcontrib-plantuml-0.25
yuja commented 1 year ago

Thank you for testing!