search

sphinx-contrib / sphinxcontrib-towncrier

An RST directive for injecting a Towncrier-generated changelog draft containing fragments for the unreleased (next) project version. Demo: https://ansible-pylibssh.rtfd.io/changelog. Docs: https://sphinxcontrib-towncrier.rtfd.io
https://pypi.org/p/sphinxcontrib-towncrier
BSD 3-Clause "New" or "Revised" License
19 stars 18 forks source link

Update build-system dependencies #80

Open dvzrv opened 1 year ago

dvzrv commented 1 year ago

pyproject.toml: Update setuptools-scm to >= 7.1.0 to drop the requirement for setuptools-scm-git-archive (since the functionality is included since 7.0.0). Update requirement for setuptools accordingly.

webknjaz commented 1 year ago

This will probably need to wait until I drop Python 3.6.

codecov[bot] commented 1 year ago

Codecov Report

Merging #80 (2fcfcb2) into master (729b600) will not change coverage. The diff coverage is n/a.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #80 +/- ## ======================================= Coverage 64.63% 64.63% ======================================= Files 14 14 Lines 246 246 Branches 30 30 ======================================= Hits 159 159 Misses 86 86 Partials 1 1 ```
dvzrv commented 1 year ago

This will probably need to wait until I drop Python 3.6.

I didn't even notice you still support 3.6. Is there a reason for it? After all, upstream already EOL'd it :)

webknjaz commented 1 year ago

I usually don't rush to drop support if there's no compelling reason to do so. Especially, in small projects, where it takes more effort than just leaving it as is. Plus, in this project it is much more important to work on adding the integration tests to improve the coverage and be able to stop shipping only alpha versions, plus use a better trove classifier for stability.

FWIW, from the Python packaging perspective, I declare minimum versions with the software features needed and then, it works with the newer versions too. Bumping the lower bound doesn't seem justified right now. But thanks for bringing this to my attention — I should really test building dists with the lowest supported deps, including the runtime/interpreter so such a breaking change would be noticeable in CI.

Re:patch — I think, that it could be acceptable now if instead of replacing the entries it made use of env markers to have them as is for Python 3.6 and only add the updated deps for Python 3.7+ (just 7.0). Note that setuptools-scm 7+ no longer declares the toml extra so it's not needed anymore. Oh, and one more thing that is missing from this patch is updating .git_archival.txt — the newer plugin version makes use of newer Git features and requires a newer template there — you can take that file from this plugin's Git tree itself.