search

sphinx-contrib / sphinxcontrib-versioning

Sphinx extension that allows building versioned docs for self-hosting.
https://sphinxcontrib-versioning.readthedocs.io/en/latest/
MIT License
125 stars 81 forks source link

Spinx 1.7+ ImportError workaround #69

Closed z00sts closed 4 years ago

z00sts commented 4 years ago

Allows you at least see application help instead of Traceback print.

Fixes #66

z00sts commented 4 years ago

@paddy-hack thanks for clarification. So you closing the PR?

paddy-hack commented 4 years ago

No, I'm not closing this PR. I'm just suggesting you fix up the comment in this/your PR so people looking at the code later don't get misled. That's all.

See https://github.com/sphinx-contrib/sphinxcontrib-versioning/issues/70#issuecomment-554632618 for some background info on this.

TimKam commented 4 years ago

Can yo control-merge master into your branch/rebase, @z00sts? Also, if I understand it correctly, updating sphinxcontrib-versioning without updating a very old Sphinx install (< 1.7) would cause problems given the changes in this PR, but IMHO we can live with this.

z00sts commented 4 years ago

I updated branch state with upstream and created new PR with correct branch-name and commit message https://github.com/sphinx-contrib/sphinxcontrib-versioning/pull/78