Closed Madders closed 1 year ago
There seems to be some problem with the warning functionality:
Exception occurred:
File "/home/motofckr9k/.local/lib/python3.6/site-packages/sphinxcontrib/video.py", line 60, in visit_video_node
logger = logging.getLogger(__name__)
NameError: name 'logging' is not defined
This seems to have fixed the issue.
in #13 I'm adding extra parameters that were missing including muted and loop, is the additionalsource still needed ?
in #13 I'm adding extra parameters that were missing including muted and loop, is the additionalsource still needed ?
For our use case it is.
We use open formats such as webm/vp9, but Apple doesn't support open formats so we provide an mp4/h264 fallback via the additionalsource
.
ok so small comments from my side:
additionalsource
is not a option of the video tag but a second source placed under the first one. What if we use a second optional argument instead. I would look like:
.. video:: primary.webm secondary.mp4
:autoplay:
:muted:
The second optional argument sounds good. That does more closely represent how it works in HTML.
In our case the warning makes absolute sense, but it should probably be opt-in.
superceeded by #19
Extra parameters added for additional browser and function support