sphinx-contrib / video

A sphinx plugin that enables embedding of HTML5 videos
https://sphinxcontrib-video.readthedocs.io
Apache License 2.0
43 stars 29 forks source link

Added extra options for muted, loop, and an additionalsource url #4

Closed Madders closed 1 year ago

Madders commented 3 years ago

Extra parameters added for additional browser and function support

JulianGro commented 3 years ago

There seems to be some problem with the warning functionality:

Exception occurred:
  File "/home/motofckr9k/.local/lib/python3.6/site-packages/sphinxcontrib/video.py", line 60, in visit_video_node
    logger = logging.getLogger(__name__)
NameError: name 'logging' is not defined
JulianGro commented 3 years ago

This seems to have fixed the issue.

12rambau commented 1 year ago

in #13 I'm adding extra parameters that were missing including muted and loop, is the additionalsource still needed ?

JulianGro commented 1 year ago

in #13 I'm adding extra parameters that were missing including muted and loop, is the additionalsource still needed ?

For our use case it is. We use open formats such as webm/vp9, but Apple doesn't support open formats so we provide an mp4/h264 fallback via the additionalsource.

12rambau commented 1 year ago

ok so small comments from my side:

JulianGro commented 1 year ago

The second optional argument sounds good. That does more closely represent how it works in HTML.

In our case the warning makes absolute sense, but it should probably be opt-in.

12rambau commented 1 year ago

superceeded by #19