search

sphinx-doc / alabaster

Lightweight, configurable Sphinx theme
http://alabaster.readthedocs.io/
Other
734 stars 186 forks source link

Fix DejaVu Sans Mono specified incorrectly #141

Closed Lahvuun closed 6 years ago

Lahvuun commented 6 years ago

The space in the font's name causes both Chrome and Firefox to fail at recognizing the font, so they then fall back to monospace (in my case Liberation Mono).

Here's the difference in Chrome: font1 font2

I only tested this on Gentoo Linux, the behavior may be different on other platforms. The font's actual name is DejaVu Sans Mono, though.

bitprophet commented 6 years ago

Thanks for the report! Weird, thought that change came from a manually tested patch but clearly somebody in the pipeline (me?!?!) didn't test it strongly enough.

Though now I'm wondering whether this font is named differently on different platforms (as you suggest), which would imply we want to stick both variants in here...I'll test on my end real quick.

bitprophet commented 6 years ago

Ah, I may be thinking of the regular font family, the code font family has probably been unchanged for some time (not sure that makes this any better...).

Also its current value starting with Consolas and Menlo explains why I and many others would never have hit this, as modern versions of macOS contain one or both of those and never get to seeking Deja Vu.

bitprophet commented 6 years ago

OK, my (macOS 10.12 Sierra) system has no Deja anything whatsoever, so I can't natively test this.

However a quick Google confirms your assertion that there's no space, so I'm happy to consider this a straight up typo. Thanks!