search

sphinx-doc / alabaster

Lightweight, configurable Sphinx theme
http://alabaster.readthedocs.io/
Other
723 stars 185 forks source link

logo_name = None not handled properly, appears in sidebar #216

Open sloria opened 5 months ago

sloria commented 5 months ago

Related to the fix for #215 in https://github.com/sphinx-doc/alabaster/commit/39cbbc1b614876118ce1d3209b04ea0c642033b5 .

I worked around the previous issue #215 by setting logo_name to None in html_theme_options:

html_theme_options = {
    "logo": "marshmallow-logo.png",
    "logo_name": None,
    # ...
}

but when I upgrade to alabaster 0.7.16, None appears in the sidebar

Firefox 2024-01-18 at 12 45 36

This is easily fixed by removing the logo_name setting, but the template should also properly handle None.

picnixz commented 4 months ago

PR welcome !