support arbitrary source URLs, closes #87

sphinx-doc / alabaster

Lightweight, configurable Sphinx theme

http://alabaster.readthedocs.io/

Other

738 stars 189 forks source link

support arbitrary source URLs, closes #87 #88

Open anarcat opened 8 years ago

anarcat commented 7 years ago

... ping?

anarcat commented 7 years ago

added docs and changelog entries for this - anything missing?

abitrolly commented 5 years ago

Needs to be rebased.

anarcat commented 5 years ago

Needs to be rebased.

What are the odds of this being merged if I go through that effort? That PR has been idle for two years without feedback so I'm hesitant in working anymore on it.

abitrolly commented 5 years ago

I think odds are low. Thanking @bitprophet and asking how things are on the other side of the world might help to understand if he has time for the review. Otherwise it is just a good git practice.

You may be interested to know how to add arbitrary source URLs without patching this theme.

https://github.com/release-monitoring/anitya/pull/693/commits/84c7812ff600b8d86d048e18986fd3f8cce09a29#diff-cac3dc3bfd42bc240bc9eb924f8dbfdd

abitrolly commented 5 years ago

Made it into separate snippet and preserved your parameter name https://gist.github.com/abitrolly/12522b399c92606d7b09e9342c3f788b

anarcat commented 5 years ago

i resolved the merge conflict at least now...

abitrolly commented 5 years ago

You can try to rebase that instead.