search

sphinx-doc / sphinx-autobuild

Watch a Sphinx directory and rebuild the documentation when a change is detected. Also includes a hot-reload web server.
MIT License
523 stars 75 forks source link

[ENH] Add --keep-going #109

Closed cblegare closed 1 year ago

cblegare commented 3 years ago

Fixes #108

Add --keep-going

welcome[bot] commented 3 years ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.
Welcome to the EBP community! :tada:

welcome[bot] commented 1 year ago

Congrats on your first merged pull request in this project! :tada: congrats
Thank you for contributing, we are very proud of you! :heart:

julian-poidevin commented 11 months ago

@cblegare Thank for this patch, I'm trying to use the --keep-going argument but this is failing (I manually installed commit https://github.com/executablebooks/sphinx-autobuild/commit/6af4e40e1f0ad51b11f0d03780c5a220ba1e8bbb version) . Am I using it wrongly or is this a bug (in which case I'll open an issue).

Here's my command : 

sphinx-autobuild --open-browser "source" "build" -D version=1.3 -D release=1.3.0 -W --keep-going

Here's the error : 

Traceback (most recent call last):
  File "/workspaces/comboard-linux-image/docs/.venv/bin/sphinx-autobuild", line 8, in <module>
    sys.exit(main())
  File "/workspaces/comboard-linux-image/docs/.venv/src/sphinx-autobuild/src/sphinx_autobuild/cli.py", line 174, in main
    build_args, pre_build_commands = _get_build_args(args)
  File "/workspaces/comboard-linux-image/docs/.venv/src/sphinx-autobuild/src/sphinx_autobuild/cli.py", line 21, in _get_build_args
    val = getattr(args, arg)
AttributeError: 'Namespace' object has no attribute '-keep-going'
make: *** [Makefile:58: livehtml] Error 1