sphinx-doc / sphinx-autobuild

Watch a Sphinx directory and rebuild the documentation when a change is detected. Also includes a hot-reload web server.
MIT License
524 stars 75 forks source link

Fix TypeError #42

Closed momijiame closed 8 years ago

momijiame commented 8 years ago

python-livereload's API is changed in v2.4.1. 'ignore' keyword is added to Watcher#watch(). This change brings about TypeError in sphinx-autobuild.

$ sphinx-autobuild -b singlehtml source build/singlehtml
Traceback (most recent call last):
  File "/Users/amedama/.virtualenvs/sphinx-ab/bin/sphinx-autobuild", line 11, in <module>
    sys.exit(main())
  File "/Users/amedama/.virtualenvs/sphinx-ab/lib/python3.5/site-packages/sphinx_autobuild/__init__.py", line 280, in main
    server.watch(srcdir, builder)
  File "/Users/amedama/.virtualenvs/sphinx-ab/lib/python3.5/site-packages/livereload/server.py", line 203, in watch
    self.watcher.watch(filepath, func, delay, ignore=ignore)
TypeError: watch() got an unexpected keyword argument 'ignore'

Therefore, we should add the parameter to LivereloadWatchdogWatcher#watch().

momijiame commented 8 years ago

Also the workaround of this issue is the following.

$ pip install -U livereload==2.4.0
momijiame commented 8 years ago

This have duplicated with #41