sphinx-doc / sphinx-doc-translations

Translations for Sphinx's documentation
Other
22 stars 16 forks source link

Improve the CI and the translation in readthedocs #38

Closed rffontenelle closed 4 months ago

rffontenelle commented 5 months ago

This greatly improves the CI workflow of sphinx-doc-translations, by simplify some statements in CI workflow, removing obsolete PO files and removing obsolete Transifex resources.

Footnotes:

¹ Example of issue: In pull requests, changes to updates.sh in the branch would not be used because git checkout master was changing the current branch during the workflow run, effectively making the workflow use updates.sh from master branch.

² locking resources needed POT and .tx/config generated, but not the translations pulled. So splitting seemed to be the best alternative. Other alternative was to set up another GHA job in same file and duplicate lines of statements checkout, dependencies installation, etc.

³ Fixes #40

4 Fixes #42

5 Fixes #41

rffontenelle commented 4 months ago

https://readthedocs.org/api/v2/build/24311043.txt

loading translations [pt-br]... WARNING: reading error: /home/docs/checkouts/readthedocs.org/user_builds/sphinx-pt-br/checkouts/38/locale/pt-br/LC_MESSAGES/sphinx.po, expected only letters, got 'pt-br'

rffontenelle commented 4 months ago

@AA-Turner Would you like to review this? Asking just to know if I wait or merge