search

sphinx-doc / sphinx-doc-translations

translated docs for sphinx official document
Other
21 stars 16 forks source link

fix misspelling of sphinx.ext.imgconverter #50

Closed kartben closed 3 weeks ago

kartben commented 3 weeks ago

This can cause french users to use a wrong ID for the extension if they don't pay attention

rffontenelle commented 3 weeks ago

Thanks for your patch. It is indeed a very important fix! However, translations happens in Transifex and they are downloaded replacing the content in the repository, meaning your fix would be undone.

Would you be willing to fix this in Transifex to make it permanent? Otherwise let me know and I'll handle this somehow.

kartben commented 3 weeks ago

@rffontenelle Ah, thanks! I was suspecting something like that but couldn't find any instructions on how to contribute translations so made a PR :) I think I fixed it, https://app.transifex.com/sphinx-doc/sphinx-doc/translate/#fr/usage--extensions--imgconverter/146745721 -- please close the PR if this looks good to you or let me know if I made the edit against the wrong project or version

rffontenelle commented 3 weeks ago

@kartben Thanks of fixing it. You may have noticed in the checks of this PR that we are testing translations and reporting build warnings and lint warnings for all languages. If you have time, please consider checking the details of French translation of finding the issues to fix.

I'll be closing this PR, but feel free to ask me more information if needed.