search

sphinx-doc / sphinx-intl

A Sphinx utility that make it easy to translate and to apply translations.
https://sphinx-intl.readthedocs.io/
BSD 2-Clause "Simplified" License
74 stars 38 forks source link

Set resource_name in .tx/config files to preserve resource naming behavior prior to 2.1.0 #90

Closed jpmckinney closed 1 year ago

jpmckinney commented 1 year ago

closes #88

jpmckinney commented 1 year ago

@m-aciek I've added a test and updated my commit with the suggestion.

rffontenelle commented 1 year ago

Confirmed it is working. It successfully adds "resource_name" field to each resource entry and pushing to Transifex sends the expected resource name. Thanks for that!

Can you also add a Feature entry to CHANGES file?

jpmckinney commented 1 year ago

I've added an entry :)

jpmckinney commented 1 year ago

Is there anything blocking a merge?

AA-Turner commented 1 year ago

@jpmckinney tests failed on master, please could you provide a fix? Otherwise we'll need to revert.

A

jpmckinney commented 1 year ago

I'll look into it!

jpmckinney commented 1 year ago

I'm unable to reproduce and I installed the same versions of packages as listed by pip freeze in the workflow.

jpmckinney commented 1 year ago

Aha, something changed in tx between 1.6.7 and 1.6.10. Looks like failures start with 1.6.8.

jpmckinney commented 1 year ago

Okay, tx just changed the whitespace alignment: https://github.com/sphinx-doc/sphinx-intl/pull/96