birkenfeld
commented
9 years ago Thanks for getting back. We'll have a look!
Open shimizukawa opened 9 years ago
birkenfeld
commented
9 years ago Thanks for getting back. We'll have a look!
jdillard
commented
1 year ago It seems like this issue can be closed due to inactivity.
atagar
commented
1 year ago Up to you. I submitted this almost a decade ago and never heard back. If you have a question for me about it I'd be happy to talk but from what I can tell there's no action needed on my end.
Cheers! -Damian (the original bitbucket reporter)
jdillard
commented
1 year ago This is where the haiku theme is located: https://github.com/sphinx-doc/sphinx/tree/master/sphinx/themes/haiku
If you still want to make the patch, I say go for it! Although I personally think the previous and next functionality should be maintained somewhere in the theme instead of being replaced.
atagar
commented
1 year ago Although I personally think the previous and next functionality should be maintained somewhere in the theme instead of being replaced.
Sorry, I'm unsure what you mean.
After so many years of crickets I'm wary of making a patch just to have it similarly dropped. The code change was tiny (just some CSS tweaks) and the demo of its functionality is still live.
The goal of this ticket was always to see if the upstream Sphinx project (or Haiku theme) wanted this. If the answer is 'no thanks' that's perfectly fine too.
jdillard
commented
1 year ago Sorry, I'm unsure what you mean.
It may a more recent change, but on the latest version of the theme it looks like there are previous/current/next page links on the right side of the top nav bar: https://sphinx-themes.org/sample-sites/default-haiku/
The goal of this ticket was always to see if the upstream Sphinx project (or Haiku theme) wanted this. If the answer is 'no thanks' that's perfectly fine too.
I'm not a maintainer, I was just poking around old issues and didn't realize you were watching the thread (most OPs from bitbucket aren't), but there has been talk of re-evaluating bundled themes, so given that I'm not sure how high a priority change that would be: https://github.com/sphinx-doc/sphinx/issues/10672
Hi, well over a year back I offered to submit a patch that adds menus for the Haiku theme...
example: https://stem.torproject.org/ list post: https://groups.google.com/forum/#!topic/sphinx-users/uKCqCkw-ya8 patch where we added it: https://gitweb.torproject.org/stem.git/commit/?id=c719b1e5680898e9d1f6ede953b3169d12580f64
I never heard back so shrugged and said 'meh, whatever'. But this is a pretty slick feature and I could send you an upstream patch adding a conf.py option if you'd like. Feel free to close this if such a patch wouldn't be of interest.
Cheers! -Damian