sphinx-doc / sphinxcontrib-django

This is a sphinx extension which improves the documentation of Django apps.
https://pypi.org/project/sphinxcontrib-django/
Apache License 2.0
43 stars 25 forks source link

Use field.name for DeferredAttributes for Django 3.x, fixes #20 #21

Closed miterion closed 4 years ago

miterion commented 4 years ago

This PR should fix #20

I did not found a way to force the usage of a DeferredAttribute and could therefore not write a test case.

codecov-io commented 4 years ago

Codecov Report

Merging #21 into master will decrease coverage by 0.83%. The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #21      +/-   ##
=======================================
- Coverage   57.84%   57%   -0.84%     
=======================================
  Files           6     6              
  Lines         204   207       +3     
=======================================
  Hits          118   118              
- Misses         86    89       +3
Impacted Files Coverage Δ
sphinxcontrib_django/docstrings.py 41.44% <0%> (-0.84%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5508cf0...9653a19. Read the comment docs.

vdboor commented 4 years ago

Thanks for the fix!