search

sphinx-doc / sphinxcontrib-django

This is a sphinx extension which improves the documentation of Django apps.
https://pypi.org/project/sphinxcontrib-django/
Apache License 2.0
43 stars 25 forks source link

Drop Python 2, drop Django<2.2 #25

Closed therefromhere closed 1 year ago

therefromhere commented 4 years ago

Fixed Django 4.0 deprecation warning (resolves #24)

codecov-io commented 4 years ago

Codecov Report

Merging #25 into master will decrease coverage by 0.46%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
- Coverage   62.67%   62.21%   -0.47%     
==========================================
  Files           6        6              
  Lines         217      217              
==========================================
- Hits          136      135       -1     
- Misses         81       82       +1
Impacted Files Coverage Δ
sphinxcontrib_django/docstrings.py 45.63% <100.00%> (-1.35%) :arrow_down:
sphinxcontrib_django/tests/test_docstrings.py 98.07% <0.00%> (+1.92%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5417a32...65ecf65. Read the comment docs.

timobrembeck commented 1 year ago

@therefromhere Thanks a lot for your PR, I now took over maintenance for this package and merged the changes of my fork back into this repo. These changes also include 66703432c8b5704b5bcbeca13a3fc93fa93e19fc which fixes the original issue.