Closed timobrembeck closed 1 year ago
Merging #28 into master will increase coverage by
4.45%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #28 +/- ##
==========================================
+ Coverage 62.67% 67.12% +4.45%
==========================================
Files 6 6
Lines 217 219 +2
==========================================
+ Hits 136 147 +11
+ Misses 81 72 -9
Impacted Files | Coverage Δ | |
---|---|---|
sphinxcontrib_django/docstrings.py | 53.02% <100.00%> (+6.04%) |
:arrow_up: |
sphinxcontrib_django/tests/test_docstrings.py | 96.29% <100.00%> (+0.14%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 5417a32...24eca6b. Read the comment docs.
Hi @vdboor, do you still maintain this project? If not, would you accept help? I would prefer to contribute to this project than to work on my own fork.
This was fixed in 52dce804affab2b28e6f35cc0fc2e9f66efe498d
Add form fields for all forms which inherit from
django.forms.BaseForm
(e.g.django.forms.ModelForm
), not only from forms inheriting fromdjango.forms.Form
.The method
_add_form_fields()
only uses the form attributebase_fields
which is defined in theBaseForm
-class, so the method should work for any kind of django forms, no matter their inheritance path.Fixes #27