search

sphinx-doc / sphinxcontrib-django

This is a sphinx extension which improves the documentation of Django apps.
https://pypi.org/project/sphinxcontrib-django/
Apache License 2.0
45 stars 25 forks source link

Added some basic compatibility with Django 2.x series #4

Closed mauler closed 6 years ago

mauler commented 6 years ago

The code isn't optimal, we needs tests and other stuff.

vdboor commented 6 years ago

Hi! Thanks for providing this pull request! It doesn't seem to be compatible with another change in master, where the to field also handles string values (e.g. "auth.User"). Could you look into this?

The Django version check can also be done using if django.VERSION >= (2, 0) which might be a bit cleaner.

vdboor commented 6 years ago

I've merged your changes manually in 6525fb014f88d7eefe0ac1a00c0d19a0ea3a55c8 and added the first test case. Thanks for reaching out!