search

sphinx-doc / sphinxcontrib-django

This is a sphinx extension which improves the documentation of Django apps.
https://pypi.org/project/sphinxcontrib-django/
Apache License 2.0
43 stars 25 forks source link

GitHub Actions: Upgrade to codecov v4 #70

Closed cclauss closed 1 month ago

cclauss commented 6 months ago

Short description

GitHub Actions: Upgrade to codecov v4

Proposed changes

Resolved issues

Fixes: #69

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.64%. Comparing base (e9d4308) to head (8339a13).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #70 +/- ## =========================================== - Coverage 100.00% 99.64% -0.36% =========================================== Files 10 20 +10 Lines 328 559 +231 =========================================== + Hits 328 557 +229 - Misses 0 2 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cclauss commented 6 months ago

Snap!

cclauss commented 6 months ago

setup.py usually goes untested and more and more it is just getting removed.

timobrembeck commented 6 months ago

setup.py usually goes untested and more and more it is just getting removed.

* https://setuptools.pypa.io/en/latest/deprecated/commands.html

Right, I'm also fine with removing it. :+1: It should have no downsides for users installing this package via pip, right?

cclauss commented 6 months ago

Let's not lose setup.py in this pull request. I doubt the loss of one-third of 1% is caused by the presence of setup.py. Once this PR is merged then 99.64% will be the coverage's new normal (green). See section 06 of https://about.codecov.io/resource/what-is-code-coverage on why 100% coverage is not vital.