search

sphinx-doc / sphinxcontrib-django

This is a sphinx extension which improves the documentation of Django apps.
https://pypi.org/project/sphinxcontrib-django/
Apache License 2.0
43 stars 25 forks source link

Use the string as cls_path if the related_model is specified as a string #9

Closed zd42 closed 6 years ago

zd42 commented 6 years ago

Sorry for the merge request clutter, but I didn't see that the same assumption was made elsewhere too.

codecov-io commented 6 years ago

Codecov Report

Merging #9 into master will decrease coverage by 1.99%. The diff coverage is 9.09%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #9   +/-   ##
=======================================
- Coverage   58.98%   56.98%   -2%     
=======================================
  Files           6        6           
  Lines         178      186    +8     
=======================================
+ Hits          105      106    +1     
- Misses         73       80    +7
Impacted Files Coverage Δ
sphinxcontrib_django/docstrings.py 41.6% <9.09%> (-1.81%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8099c44...3d588ff. Read the comment docs.

vdboor commented 6 years ago

Thanks for the PR! I'm quite surprised to learn that this issue could still occur. Could you also write a unit that that shows this situation?