sphinx-labs / sphinx

DevOps platform for smart contract deployments
MIT License
237 stars 15 forks source link

fix(pg): Remove tx data from proposal request #1679

Closed RPate97 closed 5 months ago

RPate97 commented 5 months ago

Purpose

Removes the transaction data from the proposal request gas estimates

We still need this data to properly estimate the cost of deployments on OP stack networks, but we should not supply it this way via proposals because we can exceed the request size limit in extreme cases. I thought this was quite unlikely to occur, but this is what happened with Centrifudges deployment. I will need to reconsider how to go about estimating the deployment cost on OP stack chains without having this data immediately available in the proposal API endpoint.

Note that this change is not required to unblock Centrifuge, I resolved their issue with a minor change on the website. This PR eliminates the possibility of it happening to anyone else.

Disables transaction batching on Arbitrum

As a precaution, I tested out deploying on the testnets of all the networks Centrifuge wants to deploy on. I found that the calldata size was an issue on Arbitrum, so I've temporarily disabled batching on the network to ensure their deployment is smooth.

Since Arbitrum has an insanely high block gas limit, our system attempts to execute their entire deployment (~40 transactions and 12 contract deployments in a single massive transaction).