search

sphinx-themes / sphinx-themes.org

A showcase for Sphinx documentation themes
https://sphinx-themes.org
BSD 2-Clause "Simplified" License
233 stars 43 forks source link

Update ci.yaml to use newer pre-commit version, v3.0.0 #130

Closed shirou closed 1 year ago

shirou commented 1 year ago

https://github.com/pre-commit/action/tree/main

this action is in maintenance-only mode and will not be accepting new features. generally you want to use pre-commit.ci which is faster and has more features.

hmm. Should we stop using this action? or move to pre-commit.ci?

pradyunsg commented 1 year ago

@shirou I've filed #131 to fix the pre-commit failures. The failure is basically https://github.com/PyCQA/isort/pull/2078 :)

I think adopting pre-commit.ci isn't strictly necessary but if you think that's preferable, please feel welcome to add that! We should remove the pre-commit CI job then and change the required checks to require pre-commit.ci's check instead of the current pre-commit check from GitHub Actions.

shirou commented 1 year ago

fixed by #131

shirou commented 1 year ago

I think no need to move to pre-commit.ci. (sorry for pre-commit authors). And since github actions now work due to your excellent PR #131, I'm happy to keep it the way it is for the time being.