sphuber / aiida-shell

AiiDA plugin that makes running shell commands easy.
MIT License
14 stars 7 forks source link

`launch_shell_job`: Move `computer` to top-level of `metadata` #98

Closed sphuber closed 2 months ago

sphuber commented 2 months ago

The metadata passed to the launch_shell_job is just supposed to expose the same input of the ShellJob and essentially forward it. However, the computer input was expected to be passed nested inside the options namespace, even though it is defined as a top-level metadata input. This makes the inputs for launch_shell_job dfifferent from the ShellJob causing unnecessary confusion. The computer input should now be specified as a top-level metadata input for the launch_shell_job wrapper as well.